[Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D15428#308401, @zturner wrote:

> In hindsight I wonder if I even needed to manually mark the test with a debug info.  Maybe we can say that tests should *never* be manually marked with a debug info category, and only use the skip decorators.  That should still work, because it will be auto-multiplied to every debug format, and then some of them will be skipped.


I quite like that. `@dwarf_test` essentially means "skip if debug info is not dwarf", so why not state that explicitly... I'm not going to ask you to rewrite it again, but if you feel like it, then by all means go for it.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:2227-2228
@@ +2226,4 @@
+
+                # If any debug info categories were explicitly tagged, assume that list to be
+                # authoritative.  If none were specified, try with all debug info formats.
+                all_dbginfo_categories = set(test_categories.debug_info_categories)
----------------
tberghammer wrote:
> I think this won't work if the list of debug info formats are specified on class level instead of at function level.
That's true, but given that it's difficult to access the class annotations from this context, I'm fine with living with this "defect", at least for now. Although, it sounds like that if we go with the option Zachary proposes, this problem would go away...


http://reviews.llvm.org/D15428