[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 11 14:04:44 PST 2015
No, sadly. We still have 4 space indentation, allman style braces, 120
line character limit, return-type-on-separate-line, and a few other
differences <http://lldb.llvm.org/lldb-coding-conventions.html>. I've
tried on a couple of occasions to remove some of these differences and move
closer to LLDB's style, but it has never gone over well. I plan to keep
trying until I'm dead or working on something else, so if there's anything
you can do to help, it would be great :)
On Fri, Dec 11, 2015 at 2:01 PM Todd Fiala <todd.fiala at gmail.com> wrote:
> On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner <zturner at google.com>
>> On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits <
>> lldb-commits at lists.llvm.org> wrote:
>>> Hey Eugene and Greg,
>>> I thought we were doing spaces before the open parens in places like
>>> - BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine
>>> + BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine(
>>> (see the removal of the space after BreakpointResolverFileLine from the
>>> clang-tidy settings I presume).
>>> Did I misunderstand that?
>> This was officially removed from the coding standard some months ago,
> Okay. Are we 100% in sync with LLVM coding standard guidelines? If so I
> can just look there to see what we're supposed to be doing.
>> but not everyone has adopted this unfortunately. See r228860. It pains
>> me to no end that we differ from LLVM, because it leads to exactly these
>> type of problems where people aren't sure what the exact set of rules are.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits