[Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 11 10:32:07 PST 2015


jingham added a subscriber: jingham.
jingham added a comment.

This patch is not acceptable as is.  It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do.  As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled flavor against Itanium and MSVC.  So it shouldn’t be hard to replace the errant usage.  Do that and its fine to go in.

Jim


Repository:
  rL LLVM

http://reviews.llvm.org/D15326





More information about the lldb-commits mailing list