[Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 11 09:54:34 PST 2015

zturner added a comment.

In http://reviews.llvm.org/D15428#308131, @labath wrote:

> The interaction between the `add_test_categories` and the "magic test multiplier" is causing problems, which is evident in the fact how you needed to add the `@skip` decorator to make it work.
> It sounds like we need to decide what will be the "correct" interaction of the "test multiplier" and tests manually marked with a specific debug info.
> I think the most sensible behavior would be to treat a manual debuginfo mark as a signal that you don't want your test to be auto-multiplied, the test multiplier could then check whether the test is already marked with one of the debuginfo annotations, and if it is, then avoid touching it.

In hindsight I wonder if I even needed to manually mark the test with a debug info.  Maybe we can say that tests should *never* be manually marked with a debug info category, and only use the skip decorators.  That should still work, because it will be auto-multiplied to every debug format, and then some of them will be skipped.


More information about the lldb-commits mailing list