[Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."
Todd Fiala via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 11 09:24:46 PST 2015
(And by ridiculous, I mean the idea of having something time out, and
having that be an expected condition just to keep the test red, is a heavy
indication that something else needs to change --- feels like a bandaid on
top of a bad patch job --- something I think we want to address at a more
holistic level, which hopefully the low load test pass will help. I think
increasing the timeout would be a better way to handle that in the short
On Fri, Dec 11, 2015 at 9:22 AM, Todd Fiala <todd.fiala at gmail.com> wrote:
> I think this (the expected timeout) will go away once I'm done with the
> low-load, single-worker follow up pass, fwiw. If that is not the case, we
> should be disabling tests that intermittently timeout for reasons other
> than high load.
> On Fri, Dec 11, 2015 at 9:21 AM, Todd Fiala <todd.fiala at gmail.com> wrote:
>> "Expected timeout" - that concept is ridiculous.
>> Why not increase the timeout?
>> On Fri, Dec 11, 2015 at 3:06 AM, Pavel Labath via lldb-commits <
>> lldb-commits at lists.llvm.org> wrote:
>>> Author: labath
>>> Date: Fri Dec 11 05:05:24 2015
>>> New Revision: 255335
>>> URL: http://llvm.org/viewvc/llvm-project?rev=255335&view=rev
>>> Revert "Turn on new test summary results by default."
>>> The new test summary formatter does not honor the "expected timeout"
>>> markings, which makes our
>>> buildbots all red. I'm switching it off by default until we figure out a
>>> way to make this work.
>>> Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
>>> --- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
>>> +++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Fri Dec 11
>>> 05:05:24 2015
>>> @@ -407,12 +407,6 @@ def parseOptionsAndInitTestdirs():
>>> if args.results_formatter_options:
>>> configuration.results_formatter_options =
>>> - # Default to using the BasicResultsFormatter if no formatter is
>>> - # and we're not a test inferior.
>>> - if not args.inferior and configuration.results_formatter_name is
>>> - configuration.results_formatter_name = (
>>> if args.lldb_platform_name:
>>> configuration.lldb_platform_name = args.lldb_platform_name
>>> if args.lldb_platform_url:
>>> Modified: lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py
>>> --- lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py
>>> +++ lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py Fri
>>> Dec 11 05:05:24 2015
>>> @@ -683,9 +683,8 @@ class ResultsFormatter(object):
>>> if event_type == "terminate":
>>> self.terminate_called = True
>>> - elif event_type in [
>>> - EventBuilder.TYPE_TEST_RESULT,
>>> - EventBuilder.TYPE_JOB_RESULT]:
>>> + elif (event_type == EventBuilder.TYPE_TEST_RESULT or
>>> + event_type == EventBuilder.TYPE_JOB_RESULT):
>>> # Keep track of event counts per test/job result status
>>> # The only job (i.e. inferior process) results that
>>> make it
>>> # here are ones that cannot be remapped to the most
>>> lldb-commits mailing list
>>> lldb-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits