[Lldb-commits] [lldb] r255276 - Remove the -T option from dotest.py.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 10 10:50:49 PST 2015


Author: zturner
Date: Thu Dec 10 12:50:49 2015
New Revision: 255276

URL: http://llvm.org/viewvc/llvm-project?rev=255276&view=rev
Log:
Remove the -T option from dotest.py.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/configuration.py
    lldb/trunk/packages/Python/lldbsuite/test/dotest.py
    lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/configuration.py?rev=255276&r1=255275&r2=255276&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/configuration.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/configuration.py Thu Dec 10 12:50:49 2015
@@ -124,9 +124,6 @@ sdir_has_content = False
 # svn_info stores the output from 'svn info lldb.base.dir'.
 svn_info = ''
 
-# svn_silent means do not try to obtain svn status
-svn_silent = True
-
 # Default verbosity is 0.
 verbose = 1
 

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=255276&r1=255275&r2=255276&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Thu Dec 10 12:50:49 2015
@@ -365,9 +365,6 @@ def parseOptionsAndInitTestdirs():
     if args.t:
         os.environ['LLDB_COMMAND_TRACE'] = 'YES'
 
-    if args.T:
-        configuration.svn_silent = False
-
     if args.v:
         configuration.verbose = 2
 
@@ -701,16 +698,6 @@ def setupSysPath():
     else:
         os.environ["LLDBMI_EXEC"] = lldbMiExec
 
-    # Skip printing svn/git information when running in parsable (lit-test compatibility) mode
-    if not configuration.svn_silent and not configuration.parsable:
-        if os.path.isdir(os.path.join(lldbRootDirectory, '.svn')) and which("svn") is not None:
-            pipe = subprocess.Popen([which("svn"), "info", lldbRootDirectory], stdout = subprocess.PIPE)
-            configuration.svn_info = pipe.stdout.read()
-        elif os.path.isdir(os.path.join(lldbRootDirectory, '.git')) and which("git") is not None:
-            pipe = subprocess.Popen([which("git"), "svn", "info", lldbRootDirectory], stdout = subprocess.PIPE)
-            configuration.svn_info = pipe.stdout.read()
-        print(configuration.svn_info)
-
     lldbPythonDir = None # The directory that contains 'lldb/__init__.py'
     if configuration.lldbFrameworkPath:
         candidatePath = os.path.join(configuration.lldbFrameworkPath, 'Resources', 'Python')

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py?rev=255276&r1=255275&r2=255276&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py Thu Dec 10 12:50:49 2015
@@ -94,7 +94,6 @@ def create_parser():
     group.add_argument('-u', dest='unset_env_varnames', metavar='variable', action='append', help='Specify an environment variable to unset before running the test cases. e.g., -u DYLD_INSERT_LIBRARIES -u MallocScribble')
     group.add_argument('--env', dest='set_env_vars', metavar='variable', action='append', help='Specify an environment variable to set to the given value before running the test cases e.g.: --env CXXFLAGS=-O3 --env DYLD_INSERT_LIBRARIES')
     X('-v', 'Do verbose mode of unittest framework (print out each test case invocation)')
-    X('-T', 'Obtain and dump svn information for this checkout of LLDB (off by default)')
     group.add_argument('--enable-crash-dialog', dest='disable_crash_dialog', action='store_false', help='(Windows only) When LLDB crashes, display the Windows crash dialog.')
     group.add_argument('--show-inferior-console', dest='hide_inferior_console', action='store_false', help='(Windows only) When launching an inferior, dont hide its console window.')
     group.set_defaults(disable_crash_dialog=True)




More information about the lldb-commits mailing list