[Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 10 09:29:25 PST 2015
I like the clang specific patch here better. Mainly because if you add a function like this to TypeSystem.h:
DeclContextCountDeclLevels (void *opaque_decl_ctx,
ConstString *find_name = nullptr,
CompilerType *find_type = nullptr) = 0;
It means that you will have a function in the CompilerDeclContext named "CountDeclLevels(...)". The "DeclContext" prefix is the convention in TypeSystem.h that says "I will add a corresponding function to CompilerDeclContext that will call through to this function.
I still like the clang specific version better because I still think it doesn't make a sensible API for CompilerDeclContext.
> On Dec 9, 2015, at 9:19 PM, Dawn Perchik <dawn+llvm at burble.org> wrote:
> dawn updated this revision to Diff 42375.
> dawn added a comment.
> This version of the patch makes the API specific to clang.
> rL LLVM
More information about the lldb-commits