[Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

Dawn Perchik via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 8 15:28:56 PST 2015

dawn added a comment.

In http://reviews.llvm.org/D15326#305163, @jingham wrote:

> The part of this fix which is using info in the SymbolContext to make the language detection more accurate is fine.
> We have to do something better about how we detect the language from a mangled name.  The target knows some that it should be able to contribute, but there's no clear way to do that now.  But you aren't making that any worse (except the one inline comment about cstring_is_mangled above, which will need to get fixed) so I don't think you are obligated to solve that problem now.

Can we please accept this as is?  It helps *a lot* - we know the *exact* language whenever we have debug info for an identifier.  I've been able to remove my #if 0's around the filtering code with this patch.  As you say, it doesn't make anything worse, and for many of us makes, things are far better.  Why would you reject it?

The name mangling issue is a whole other beast - it was a flawed assumption from the start (and I complained about it then).  I'm simply trying to make the best with what we have.



More information about the lldb-commits mailing list