[Lldb-commits] [lldb] r255041 - Remove the -g option from dotest.py

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 8 10:48:54 PST 2015

Author: zturner
Date: Tue Dec  8 12:48:53 2015
New Revision: 255041

URL: http://llvm.org/viewvc/llvm-project?rev=255041&view=rev
Remove the -g option from dotest.py

This removes the non-exclusive filterspec option as part of an
effort to remove unused / deprecated command line options from


Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/configuration.py?rev=255041&r1=255040&r2=255041&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/configuration.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/configuration.py Tue Dec  8 12:48:53 2015
@@ -120,11 +120,6 @@ filters = []
 # Use '-k' to specify a runhook.
 runHooks = []
-# If '-g' is specified, the filterspec is not exclusive.  If a test module does
-# not contain testclass.testmethod which matches the filterspec, the whole test
-# module is still admitted into our test suite.  fs4all flag defaults to True.
-fs4all = True
 # Ignore the build search path relative to this script to locate the lldb.py module.
 ignore = False

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=255041&r1=255040&r2=255041&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Tue Dec  8 12:48:53 2015
@@ -339,9 +339,6 @@ def parseOptionsAndInitTestdirs():
         # output-on-success.
         configuration.no_multiprocess_test_runner = True
-    if args.g:
-        configuration.fs4all = False
     if args.i:
         configuration.ignore = True
@@ -915,8 +912,7 @@ def visit(prefix, dir, names):
             # Forgo this module if the (base, filterspec) combo is invalid
-            # and no '-g' option is specified
-            if configuration.filters and configuration.fs4all and not filtered:
+            if configuration.filters and not filtered:
             # Add either the filtered test case(s) (which is done before) or the entire test class.

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py?rev=255041&r1=255040&r2=255041&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py Tue Dec  8 12:48:53 2015
@@ -61,7 +61,6 @@ def create_parser():
     group = parser.add_argument_group('Test filtering options')
     group.add_argument('-N', choices=['dwarf', 'dwo', 'dsym'], help="Don't do test cases marked with the @dsym_test/@dwarf_test/@dwo_test decorator by passing dsym/dwarf/dwo as the option arg")
     group.add_argument('-f', metavar='filterspec', action='append', help='Specify a filter, which consists of the test class name, a dot, followed by the test method, to only admit such test into the test suite')  # FIXME: Example?
-    X('-g', 'If specified, the filterspec by -f is not exclusive, i.e., if a test module does not match the filterspec (testclass.testmethod), the whole module is still admitted to the test suite')
     X('-l', "Don't skip long running tests")
     group.add_argument('-p', metavar='pattern', help='Specify a regexp filename pattern for inclusion in the test suite')
     group.add_argument('-X', metavar='directory', help="Exclude a directory from consideration for test discovery. -X types => if 'types' appear in the pathname components of a potential testfile, it will be ignored")

More information about the lldb-commits mailing list