[Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

Dawn Perchik via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 8 02:02:48 PST 2015

dawn added a comment.

bloodbath:~% exit
Thanks Greg!  To address your main point:

> So either make it generic, or clang specific.

DeclContextCountDeclLevels's interface follows DeclContextFindDeclByName (authored by Paul Herman).  If DeclContextCountDeclLevels is to change, then DeclContextFindDeclByName should also change for consistency.

My take on this is that the code in ClangExpressionDeclMap::FindExternalVisibleDecls which calls these scope-based lookup routines should be moved out of ClangExpressionDeclMap.cpp into CompilerExpressionDeclMap.cpp, so the interfaces to DeclContextFindDeclByName/DeclContextCountDeclLevels should remain generic while the implementations are compiler specific.  That's way more than I'd like to take on as part of this patch however.

Paul, any feedback from you on this?



More information about the lldb-commits mailing list