[Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

[Jim Ingham via lldb-commits]

jingham added a comment.

The test that test "Only breakpoint conditions" will always have LLDB_INVALID_ID for the breakpoint thread ID.  That means the thread test is a no-op.  So it doesn't test the case "thread passes, condition doesn't" or "condition passes, thread doesn't".  I wrote this test because I didn't do those combinations correctly at some point and wanted to make sure they didn't regress.

Do you have an example of a fail when it is flakey?  This doesn't seem like a particularly sensitive test, other than it runs a bunch of threads through a bunch of breakpoints so it might just time out overall.

But it is a pretty simple test.  Grab the first thread that hits a breakpoint, set a condition and thread ID on the breakpoint, and continue and you should just run to exit.

If it is just timing out over-all that's probably just because I made it pass too many times through the worker loop.  You could probably either reduce the number of threads from 10 to something smaller, or reduce the number of times through the loop from 20 to something smaller.


http://reviews.llvm.org/D15241