[Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 4 09:18:13 PST 2015


jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

OK.  It would have been better to make a patch that fixes the specific problem with other C variants.  That's just a straight up bug, and mixing it with comments on the two separate issues, actually determining the language correctly and target language setting vrs. breakpoint language setting, confuses the real point of the patch.  Adding in the rename further obscures the issue.  We might get into a debate about the name, revert the patch, and end up re-introducing the actual bug you fixed...


Repository:
  rL LLVM

http://reviews.llvm.org/D15175





More information about the lldb-commits mailing list