[Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 3 16:38:55 PST 2015
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:312
@@ +311,3 @@
+ // necessary to test for any of the bits that provide that access type.
+ const bool readable =
+ entry->Protect & (PAGE_EXECUTE_READ | PAGE_EXECUTE_READWRITE | PAGE_READONLY | PAGE_READWRITE);
`ProcessWindowsLive::GetMemoryRegionInfo` already has this same logic built in. Would it be worth putting something in `Plugins/Process/Windows/Common` that does this conversion and then calling into it from both here and `ProcessWindowsLive`?
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h:87-88
@@ -86,2 +86,4 @@
+ lldb_private::Error GetMemoryRegionInfo(lldb::addr_t load_addr,
+ lldb_private::MemoryRegionInfo &range_info) override;
Oh yea, I forgot to mention. `clang-format` screws this up currently. You'll have to fix this part manually :(
I keep meaning to go look at clang-format's source and make it support return type on new line, but so far you have to fix these manually.
More information about the lldb-commits