[Lldb-commits] [lldb] r253864 - [LLDB][MIPS] Getting 0 index for H/W watchpoint is not necessarily an error

Mohit K. Bhakkad via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 23 04:19:59 PST 2015


Author: mohit.bhakkad
Date: Mon Nov 23 06:19:59 2015
New Revision: 253864

URL: http://llvm.org/viewvc/llvm-project?rev=253864&view=rev
Log:
[LLDB][MIPS] Getting 0 index for H/W watchpoint is not necessarily an error

Reviewers: jaydeep.
Subscribers: bhushan, sagar, nitesh.jain, lldb-commits.
Differential Revision: http://reviews.llvm.org/D14860

Modified:
    lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp?rev=253864&r1=253863&r2=253864&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Mon Nov 23 06:19:59 2015
@@ -1092,7 +1092,7 @@ GetVacantWatchIndex (struct pt_watch_reg
             }
         }
     }
-    return 0;
+    return LLDB_INVALID_INDEX32;
 }
 
 bool
@@ -1221,7 +1221,7 @@ NativeRegisterContextLinux_mips64::SetHa
     int index = GetVacantWatchIndex (&regs, addr, size, watch_flags, NumSupportedHardwareWatchpoints());
 
     // New watchpoint doesn't fit
-    if (!index)
+    if (index == LLDB_INVALID_INDEX32)
     return LLDB_INVALID_INDEX32;
 
 




More information about the lldb-commits mailing list