[Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Fix the caps on the error message, remove the new files and inline the code and this will be ready.


================
Comment at: source/API/SBProcess.cpp:1445
@@ +1444,3 @@
+    {
+        error.SetErrorString("The process is not stopped");
+        return error;
----------------
remove the caps on "The" so it it just "the".

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:159
@@ +158,3 @@
+{
+    return SaveMiniDump(process_sp, outfile, error);
+}
----------------
I would rather just have the code from SaveMiniDump inlined in this file, no need for a new file just for one function.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFMiniDump.cpp:52-53
@@ +51,4 @@
+#endif
+    return false;
+}
+
----------------
That is fine and returning false makes more sense after reading your above comment.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFMiniDump.cpp:53-55
@@ +52,4 @@
+    return false;
+}
+
+}  // namesapce lldb_private
----------------
Remove this file and inline the code into ObjectFilePECOFF::SaveCore().

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFMiniDump.h:1-24
@@ +1,24 @@
+//===-- ObjectFilePECOFFMiniDump.h ------------------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef liblldb_ObjectFilePECOFFMiniDump_h_
+#define liblldb_ObjectFilePECOFFMiniDump_h_
+
+#include "lldb/Target/Process.h"
+
+namespace lldb_private {
+
+bool
+SaveMiniDump(const lldb::ProcessSP &process_sp,
+             const lldb_private::FileSpec &outfile,
+             lldb_private::Error &error);
+
+}  // namespace lldb_private
+
+#endif
----------------
Remove this file and inline the code into ObjectFilePECOFF::SaveCore().


http://reviews.llvm.org/D14793