[Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

[Muhammad Omair Javaid via lldb-commits]

omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.

This patch disables forcing -marm (A32 instruction set) while running lldb testsuite on arm targets.

gcc uses -marm and -mthumb flag to choose between A32 and T32 instruction sets. For most processors A32 (arm mode) code is generated by default but many modern cpus also use T32 code generation as the default or a mix of both.

If we do not provide a flag then compiler decides the best possible code generation for the target which is most commonly used configuration.

Thats why i have removed this flag from out testing so that we can have a clarity on what is working when compiler selects both A32/T32 and T16 instructions interchangeably.

http://reviews.llvm.org/D14823

Files:
  packages/Python/lldbsuite/test/make/Makefile.rules

Index: packages/Python/lldbsuite/test/make/Makefile.rules
===================================================================
--- packages/Python/lldbsuite/test/make/Makefile.rules
+++ packages/Python/lldbsuite/test/make/Makefile.rules
@@ -164,6 +164,10 @@
 		override ARCH :=
 		override ARCHFLAG :=
 	endif
+	ifeq "$(ARCH)" "arm"
+		override ARCH :=
+		override ARCHFLAG :=
+	endif
 
 	ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES"
 		DSYM = $(EXE).debug


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14823.40652.patch
Type: text/x-patch
Size: 447 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151119/fcab8c28/attachment.bin>