[Lldb-commits] [PATCH] D14790: cmake: add -DLLDB_ALLOW_STATIC_BINDINGS=1, defaults off

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 19 02:25:40 PST 2015


labath added a comment.

A bit late to the party, but anyway... I would change the detection logic here:
Instead of `ALLOW_STATIC_BINDINGS`, have `USE_STATIC_BINDINGS`. If it's set, don't even bother checking for swig's presence and use the static bindings. If it's not set, then detect swig, and make it an error if it's not found.
I like this more because then the build will not do something completely different depending on whether it finds some binary on your system or not. I don't feel so strongly about that as in the case of curses (this is the dynamic dependency kamil was referring to) because this only kicks in if some option is specified, but I do think this provides more visibility into what the build system is doing.


http://reviews.llvm.org/D14790





More information about the lldb-commits mailing list