[Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 16 11:16:14 PST 2015


zturner added a comment.

In http://reviews.llvm.org/D14673#290280, @jingham wrote:

> If the problem is that the self of the test object doesn't always have a debug_info setting, why not just always initialize it to None?  Seems weird to have a general property like this that we don't initialize.


Gotta love Python.  But yea, that seems like a reasonable solution as well, and makes the code cleaner.

I'm still unsure if the change to the compiler here check was the result of a failure or just a drive-by change.  It always has a `getCompiler()` method right?  So why was that particular change needed?  Maybe it wasn't?


http://reviews.llvm.org/D14673





More information about the lldb-commits mailing list