[Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 9 17:22:11 PST 2015


zturner created this revision.
zturner added reviewers: granata.enrico, clayborg, tfiala.
zturner added a subscriber: lldb-commits.

The goal here is to eventually replace some code in `python-wrapper.swig` with this code.  This way it can be properly unit tested and we can easily deal with Python version differences.

the first set of patches will focus on just getting the classes in with unit tests to confirm they work, and then I will replace the code in `python-wrapper.swig` with this code.

Note that the implementation of `ResolveName` here differs from the implementation of `ResolvePythonName` in `python-wrapper.swig`.  The two methods seem equivalent to me, with this one being more straightforward, generic, and efficient.

http://reviews.llvm.org/D14524

Files:
  source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
  source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
  unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14524.39775.patch
Type: text/x-patch
Size: 8664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151110/a702bcfc/attachment-0001.bin>


More information about the lldb-commits mailing list