[Lldb-commits] [PATCH] D14197: Handle the options and parameters separator in every MI command

[Hafiz Abid Qadeer via lldb-commits]

abidh marked an inline comment as done.

================
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
     m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame, m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+    m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false));
 }
----------------
ki.stfu wrote:
> Well, I thought it's mandatory argument according to its spec: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Data-Manipulation.html
> ```
>       -data-disassemble
>          [ -s start-addr -e end-addr ]
>        | [ -f filename -l linenum [ -n lines ] ]
>        -- mode
> ```
> 
> But I think we can follow to the GDB syntax.
If you read the following, you will see that "--" is not mandatory. It says "Options occur first in the parameter list and can be delimited from normal parameters using ‘--’ (this is useful when some parameters begin with a dash)."

https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Input-Syntax.html#GDB_002fMI-Input-Syntax


http://reviews.llvm.org/D14197