[Lldb-commits] [PATCH] D13073: Add an expression parser for Go

[Ryan Brown via lldb-commits]

ribrdb added a comment.

Is this ready to submit?


================
Comment at: source/Expression/LLVMUserExpression.cpp:43-60
@@ +42,20 @@
+
+LLVMUserExpression::LLVMUserExpression(ExecutionContextScope &exe_scope, const char *expr, const char *expr_prefix,
+                                       lldb::LanguageType language, ResultType desired_type)
+    : UserExpression(exe_scope, expr, expr_prefix, language, desired_type)
+    , m_stack_frame_bottom(LLDB_INVALID_ADDRESS)
+    , m_stack_frame_top(LLDB_INVALID_ADDRESS)
+    , m_transformed_text()
+    , m_execution_unit_sp()
+    , m_materializer_ap()
+    , m_jit_module_wp()
+    , m_enforce_valid_object(true)
+    , m_in_cplusplus_method(false)
+    , m_in_objectivec_method(false)
+    , m_in_static_method(false)
+    , m_needs_object_ptr(false)
+    , m_const_object(false)
+    , m_target(NULL)
+    , m_can_interpret(false)
+    , m_materialized_address(LLDB_INVALID_ADDRESS)
+{
----------------
jingham wrote:
> Don't write initializers with the commas in front like this.  We don't do it this way anywhere else in lldb, and it looks really weird...
I've updated the clang-format config to fix this.


Repository:
  rL LLVM

http://reviews.llvm.org/D13073