[Lldb-commits] [PATCH] D14177: Better handle the arguments common to all MI commands.

Hafiz Abid Qadeer via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 29 07:45:55 PDT 2015


abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.

I observed that eclipse was passing --thread-group for many other commands
then we are currently handling. Looking at the MI documentation, the
following link states that each MI command accept the --thread and
--frame option. Looking at the GDB implementation, it seems that apart
from these 2, --thread-group is also handled the same way.

https://sourceware.org/gdb/onlinedocs/gdb/Context-management.html#Context-management

So instead of handling those arguments in every comamnds, I have moved
them into the base class and removed them from elsewhere. Now any command
can use these arguments. The patch seems big but most of the changes are
mechanical.

http://reviews.llvm.org/D14177

Files:
  packages/Python/lldbsuite/test/tools/lldb-mi/stack/TestMiStack.py
  tools/lldb-mi/MICmdBase.cpp
  tools/lldb-mi/MICmdBase.h
  tools/lldb-mi/MICmdCmdBreak.cpp
  tools/lldb-mi/MICmdCmdBreak.h
  tools/lldb-mi/MICmdCmdData.cpp
  tools/lldb-mi/MICmdCmdData.h
  tools/lldb-mi/MICmdCmdExec.cpp
  tools/lldb-mi/MICmdCmdExec.h
  tools/lldb-mi/MICmdCmdFile.cpp
  tools/lldb-mi/MICmdCmdFile.h
  tools/lldb-mi/MICmdCmdGdbSet.cpp
  tools/lldb-mi/MICmdCmdGdbSet.h
  tools/lldb-mi/MICmdCmdGdbShow.cpp
  tools/lldb-mi/MICmdCmdGdbShow.h
  tools/lldb-mi/MICmdCmdStack.cpp
  tools/lldb-mi/MICmdCmdStack.h
  tools/lldb-mi/MICmdCmdVar.cpp
  tools/lldb-mi/MICmdCmdVar.h
  tools/lldb-mi/MICmdInvoker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14177.38738.patch
Type: text/x-patch
Size: 38399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151029/91e8c9d3/attachment-0001.bin>


More information about the lldb-commits mailing list