[Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

[Adrian McCarthy via lldb-commits]

amccarth added inline comments.

================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
+#endif
\ No newline at end of file

----------------
zturner wrote:
> Put a newline here
Actually, this file is obsolete, so I'm deleting it instead.  It was included only from LocalDebugDelegate.cpp, which no longer needs it.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h:22
@@ -21,3 +21,3 @@
 
 class ProcessWinMiniDump : public lldb_private::Process
 {
----------------
zturner wrote:
> I was expecting this to also derive from `ProcessWindows`, because I thought that was the whole point of moving `ProcessWindows` to common and then making `ProcessWindowsLive` inherit from it.  Is there goign to be some work on this in a followup patch or did I misunderstand the purpose of raising that up to the common area?
Good eye!  Fixed.

The intent of this patch was to make it possible to start sharing code between the live and mini dump versions of the RegisterContextWindows classes.  (The next patch will actually do that.)  The other classes (Process, TargetThread) came along because of tight cooperation among them and the RegisterContext classes.  I wasn't really focused on making the mini dump versions deal with those (yet).  But this was trivial to fix now.


http://reviews.llvm.org/D14136