[Lldb-commits] [lldb] r251422 - Treat hostname in android URL as device id unless it matches "localhost".

Oleksiy Vyalov via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 27 10:41:36 PDT 2015


Author: ovyalov
Date: Tue Oct 27 12:41:34 2015
New Revision: 251422

URL: http://llvm.org/viewvc/llvm-project?rev=251422&view=rev
Log:
Treat hostname in android URL as device id unless it matches "localhost".

http://reviews.llvm.org/D14101


Modified:
    lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
    lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp?rev=251422&r1=251421&r2=251422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp Tue Oct 27 12:41:34 2015
@@ -196,7 +196,7 @@ PlatformAndroid::ConnectRemote(Args& arg
         return Error("URL is null.");
     if (!UriParser::Parse(url, scheme, host, port, path))
         return Error("Invalid URL: %s", url);
-    if (scheme == "adb")
+    if (host != "localhost")
         m_device_id = host;
 
     auto error = PlatformLinux::ConnectRemote(args);

Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp?rev=251422&r1=251421&r2=251422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp Tue Oct 27 12:41:34 2015
@@ -126,7 +126,7 @@ PlatformAndroidRemoteGDBServer::ConnectR
         return Error("URL is null.");
     if (!UriParser::Parse (url, scheme, host, remote_port, path))
         return Error("Invalid URL: %s", url);
-    if (scheme == "adb")
+    if (host != "localhost")
         m_device_id = host;
 
     std::string connect_url;




More information about the lldb-commits mailing list