[Lldb-commits] [PATCH] D14029: [TestBreakpointCommand] Fix after r251121

Siva Chandra via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 23 14:22:06 PDT 2015


sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.

"from __future__ import print_function" was added to the test file but
not to the embedded interpreter. This change uses file.write instead to
avoid all problems with print.

http://reviews.llvm.org/D14029

Files:
  test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py

Index: test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
===================================================================
--- test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
+++ test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
@@ -2,8 +2,6 @@
 Test lldb breakpoint command add/list/delete.
 """
 
-from __future__ import print_function
-
 import lldb_shared
 
 import os, time
@@ -52,7 +50,7 @@
 
         # Now add callbacks for the breakpoints just created.
         self.runCmd("breakpoint command add -s command -o 'frame variable --show-types --scope' 1 4")
-        self.runCmd("breakpoint command add -s python -o 'here = open(\"output.txt\", \"w\"); print(\"lldb\", file=here); here.close()' 2")
+        self.runCmd("breakpoint command add -s python -o 'here = open(\"output.txt\", \"w\"); here.write(\"lldb\\n\"); here.close()' 2")
         self.runCmd("breakpoint command add --python-function bktptcmd.function 3")
 
         # Check that the breakpoint commands are correctly set.
@@ -74,7 +72,7 @@
         self.expect("breakpoint command list 2", "Breakpoint 2 command ok",
             substrs = ["Breakpoint commands:",
                           "here = open",
-                          "print(file=here)",
+                          "here.write",
                           "here.close()"])
         self.expect("breakpoint command list 3", "Breakpoint 3 command ok",
             substrs = ["Breakpoint commands:",
@@ -178,7 +176,7 @@
         lldbutil.run_break_set_by_file_and_line (self, "main.c", self.line, num_expected_locations=1, loc_exact=True)
 
         # Now add callbacks for the breakpoints just created.
-        self.runCmd("breakpoint command add -s python -o 'here = open(\"output-2.txt\", \"w\"); print(frame, file=here); print(bp_loc, file=here); here.close()' 1")
+        self.runCmd("breakpoint command add -s python -o 'here = open(\"output-2.txt\", \"w\"); here.write(str(frame) + \"\\n\"); here.write(str(bp_loc) + \"\\n\"); here.close()' 1")
 
         # Remove 'output-2.txt' if it already exists.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14029.38264.patch
Type: text/x-patch
Size: 2133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151023/388a069c/attachment-0001.bin>


More information about the lldb-commits mailing list