[Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded
Tamas Berghammer via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 22 07:23:50 PDT 2015
tberghammer removed rL LLVM as the repository for this revision.
tberghammer updated this revision to Diff 38128.
tberghammer added a comment.
I tried out the implementation you suggests and made some measurements. The difference between the 2 implementation when attaching to LLDB is negligible (the total time spent in SymbolFileDWARF::Index differed by ~1%). The interesting part is that your implementation is faster for parsing C++ libraries (e.g. liblldb, libstdc++) while mine implementation is faster for parsing C libraries (libc, libm, libdl) and I don't understand why it is happening.
With the current measurements in place I don't feel strongly about any version, so if somebody have a strong preference then please let me know.
I plan to recommit this change after committing http://reviews.llvm.org/D13940 as that one fixes the remaining race conditions related to this change I found so far with TSAN
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6047 bytes
Desc: not available
More information about the lldb-commits