[Lldb-commits] [PATCH] D13073: Add an expression parser for Go
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 20 13:25:06 PDT 2015
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
So before getting into the details of the patch, there's a structural bit it would be nice to fix.
When I was separating out bits of the Expression machinery, I assumed that even though all expression parsers would use different front-ends to llvm, they would all use llvm & the llvm JIT to run the expressions. Your Go expression parser doesn't work that way. However, the correct thing to do, then, is the make UserExpression the empty base class, then what used to be in UserExpression should go in LLVMUserExpression, then ClangUserExpression derives from LLVMUserExpression, but GoUserExpression derives from UserExpression directly. That structure will make it easier to share the LLVM back end bits of expression running machinery, which really shouldn't go in ClangUserExpression since it isn't Clang specific.
Would you mind reworking it this way?
More information about the lldb-commits