[Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

[Eugene Leviant via lldb-commits]

evgeny777 added inline comments.

================
Comment at: include/lldb/API/SBValue.h:372
@@ +371,3 @@
+    bool
+    IsIntegerType(bool& is_signed);
+
----------------
granata.enrico wrote:
> Greg pointed me to SBType::GetBasicType() - this will return to you one of
> 
> ```
>         eBasicTypeSignedChar,
>         eBasicTypeUnsignedChar,
> 
> ```
> 
> such that you don't need to add new API to get this information
> 
> Also, even if this were necessary, it would go on SBType, definitely not SBValue
This method exists in ValueObject, so I thought it makes sense having it in SBValue also. But ok, let's use GetBasicType


http://reviews.llvm.org/D13799