[Lldb-commits] [PATCH] D13719: Fix warnings in LLDBWrapPython.cpp with gcc 4.9.

[Hafiz Abid Qadeer via lldb-commits]

abidh created this revision.
abidh added reviewers: zturner, clayborg.
abidh added a subscriber: lldb-commits.

I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc 4.9 on Linux.
"warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers [-Wcast-qual]"

Is it ok to add -Wno-cast-qual for this file in cmake for gcc. This option seems to be already present
for autotool case.

http://reviews.llvm.org/D13719

Files:
  cmake/LLDBDependencies.cmake

Index: cmake/LLDBDependencies.cmake
===================================================================
--- cmake/LLDBDependencies.cmake
+++ cmake/LLDBDependencies.cmake
@@ -191,6 +191,6 @@
   if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND
       NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
     set_property(SOURCE ${LLDB_WRAP_PYTHON}
-                 APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-sequence-point")
+                 APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-sequence-point -Wno-cast-qual")
   endif ()
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13719.37325.patch
Type: text/x-patch
Size: 524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151014/11b9d75d/attachment.bin>