[Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 12 13:20:59 PDT 2015


clayborg added a comment.

std::async is fine as long as it doesn't blow out the threads on any supported systems. We should also test doing multiple std::async calls in different places in some test only code to make sure if we run 4 std::async calls at once on different threads that we don't end up launching 4 times as many threads. So as long as std::async is limiting the number of threads globally within a process, we are good to go, else we should be sure to implement the limit using a thread pool. I sent you some code on the side that might take care of that if std::async isn't good enough. Else lets stick to the C++11 library when/where it is sufficient.


http://reviews.llvm.org/D13662





More information about the lldb-commits mailing list