[Lldb-commits] [PATCH] D13638: Add a missing Mutex Locker in ResetCurrentInlinedDepth

Keno Fischer via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 11 11:16:16 PDT 2015


loladiro created this revision.
loladiro added reviewers: clayborg, jingham.
loladiro added a subscriber: lldb-commits.
loladiro set the repository for this revision to rL LLVM.

This function reads m_frames, so it needs to lock the mutex like all other function that access m_frames. Found using AddressSanitizer.

Repository:
  rL LLVM

http://reviews.llvm.org/D13638

Files:
  source/Target/StackFrameList.cpp

Index: source/Target/StackFrameList.cpp
===================================================================
--- source/Target/StackFrameList.cpp
+++ source/Target/StackFrameList.cpp
@@ -105,6 +105,8 @@
 void
 StackFrameList::ResetCurrentInlinedDepth ()
 {
+    Mutex::Locker locker (m_mutex);
+
     if (m_show_inlined_frames)
     {        
         GetFramesUpTo(0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13638.37050.patch
Type: text/x-patch
Size: 369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151011/a2897678/attachment.bin>


More information about the lldb-commits mailing list