[Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 3 17:32:30 PDT 2015


tfiala added a comment.

Yep, that modified patch worked for both:

  cmake -DLLDB_DISABLE_LIBEDIT=1

where libedit is disabled from the build, and for the normal case where libedit is available.  In both cases it did the right thing - simple readline support with libedit and your change (minor tweaks by me solely on comments and conditional libedit), and for the no-libedit case (where it behaves as before, including the no-crash part :-) ).

If you can update the patch with that, it looks good to me.


Repository:
  rL LLVM

http://reviews.llvm.org/D13268





More information about the lldb-commits mailing list