[Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

[Kamil Rytarowski via lldb-commits]

krytarowski added inline comments.

================
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -------------------------------------*- C++ -*-===//
+//
----------------
labath wrote:
> This platform code looks like it was copy-pasted from PlatformFreeBSD. Do you anticipate making significant changes here?
> 
> If not, it might be a good idea to share this code with FreeBSD in some way (in fact there is a comment here to make this share code with PlatformPOSIX). @emaste, what do you think about this?
Yes... however I have bad experiences (mostly in Gnome) when we drag common code for rotted platforms like BSD4.4, BSD/OS and such in a single source tree paralyzing sane platform support.


Repository:
  rL LLVM

http://reviews.llvm.org/D13334