[Lldb-commits] [PATCH] D13282: [MIPS] Emulate microMIPS instructions

[Tamas Berghammer via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:683
@@ +682,3 @@
+
+    if (m_use_alt_disaasm == true)
+        decode_status = m_alt_disasm->getInstruction (mc_insn, next_inst_size, raw_insn, inst_addr, llvm::nulls(), llvm::nulls());
----------------
(nit): "if (m_use_alt_disaasm)"

================
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:775
@@ -660,2 +774,3 @@
         llvm::ArrayRef<uint8_t> raw_insn (data.GetDataStart(), data.GetByteSize());
-        decode_status = m_disasm->getInstruction (mc_insn, insn_size, raw_insn, m_addr, llvm::nulls(), llvm::nulls());
+        if (m_use_alt_disaasm == true)
+            decode_status = m_alt_disasm->getInstruction (mc_insn, insn_size, raw_insn, m_addr, llvm::nulls(), llvm::nulls());
----------------
(nit): "if (m_use_alt_disaasm)"

================
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:848-849
@@ -729,4 +847,4 @@
 
     // Our previous PC is in the RA
     row->SetRegisterLocationToRegister(dwarf_pc_mips, dwarf_ra_mips, can_replace);
 
----------------
You don't need this if you use SetReturnAddressRegister


Repository:
  rL LLVM

http://reviews.llvm.org/D13282