[Lldb-commits] [PATCH] D13267: Decide on the expression language inside UserExpression

Dawn Perchik via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 29 20:51:33 PDT 2015


dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.

Please apply requested changes, then it's good to commit.  Thanks for fixing this!


================
Comment at: source/Commands/CommandObjectExpression.cpp:306
@@ -306,7 +305,3 @@
         if (m_command_options.language != eLanguageTypeUnknown)
             options.SetLanguage(m_command_options.language);
 
----------------
These lsat 6 lines can be just:
    options.SetLanguage(m_command_options.language);

================
Comment at: source/Expression/UserExpression.cpp:526
@@ -514,2 +525,3 @@
 
+
     lldb::UserExpressionSP user_expression_sp(target->GetUserExpressionForLanguage (expr_cstr,
----------------
nit pick: remove extra line :)


http://reviews.llvm.org/D13267





More information about the lldb-commits mailing list