[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Todd Fiala via lldb-commits]

tfiala added a comment.

Ah I see I morphed all those together (the platform naming).

> ... bummed to see them under test_runner...


Heh, that's funny.  I was attempting to do a service of decluttering that top level test directory, which to me looks like somebody threw up a bunch of python code :-)  I didn't anticipate it would have the opposite effect!

We can tackle that a few ways: make it a package, which accomplishes 99% of what I was trying to do --- getting things out of that top level lldb/test, *while* still allowing tests to pull in some of that functionality if they want.  So it becomes something like:

lldb/test/lldb_platform/

  __init__.py
  ...
  the_files_.py
  ...
  test/
     the tests for the package

And then whatever is in there could be loaded by:
import lldb_platform.{whatever}
or
from lldb_platform import {whatever}

That seems totally reasonable to me.  How does that sound?


http://reviews.llvm.org/D13124