[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

[Zachary Turner via lldb-commits]

Yea, on Windows we can support core dump generation externally without
touching the python script, so that's not neded for us.

Ironically, at the system level there is a way to specify the return code
of the process when you terminate it.  And Python internally must be using
this API, because it's the only way to do it.  They just decided not to
expose that parameter through the subprocess.terminate() method, and
instead they pass their own magic value.  If someone is clever enough to
dig through python source code and figure out what value it uses, we could
use that.  But I think on Windows it's safe to assume that if you call
process.terminate(), then it was a hard terminate, and we can ignore
everything else.

Does that make sense / is easy to do?

On Mon, Sep 28, 2015 at 12:45 PM Todd Fiala <todd.fiala at gmail.com> wrote:

> tfiala added a comment.
>
>
>
> > I can get that together (assuming option #1) relatively quickly.
>
> >
>
> > I don't think we can drop the complexity of the 2-tier kill level in the
> driver, though, given the desire to support core dump generation.
>
>
> I'm not going to touch this until I hear back from you, though, Zachary.
> Anything I do on this is way beyond the time I have to allocate to it at
> this point, so I'll have to stub out a dead simple solution (i.e.
> essentially just about what it was doing before) for Windows if none of
> this sounds good for you.  I have to get OS X to stop hanging.
>
>
> http://reviews.llvm.org/D13124
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150928/15a3330f/attachment.html>