[Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

Kamil Rytarowski via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 17 17:31:35 PDT 2015


krytarowski added a comment.

In http://reviews.llvm.org/D12750#244435, @sas wrote:

> @brucem, not sure exactly what way forward you are suggesting. LLDB build system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we bump that to 3.0. Are we recommending we do that?


Can we do this later, after merging this change at it is? For now I won't be able to test the new approach.

In http://reviews.llvm.org/D12750#248348, @sas wrote:

> I'm fine with this patch the way it is. Unless @brucem refuses, I'll submit it. Improving cmake checks can be dealt with later on.


We have got CMake 2.8 set as the minimal requirement.

  cmake_minimum_required(VERSION 2.8)

I'm willing to push NetBSD bits first and then refactor for all platforms.

Are you OK with it @brucem?


Repository:
  rL LLVM

http://reviews.llvm.org/D12750





More information about the lldb-commits mailing list