[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 15 17:47:13 PDT 2015


clayborg added a comment.

Ah, the test_with_dsym_and_run_command() wasn't marked as fail...

I fixed the test with:

% svn commit
Sending        test/lang/cpp/nsimport/TestCppNsImport.py
Transmitting file data .
Committed revision 247764.

Feel free to correct it. I would also say that we might want to split up the test into multiple test functions so we can test individual things:

- that using namespace works with no ambiguity
- that you can see variables by specifying the global namespace and by specifying the namespace (like I just added with "::imported" and "Imported::imported")
- anything else I missed..


http://reviews.llvm.org/D12658





More information about the lldb-commits mailing list