[Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3892-3893
@@ +3891,4 @@
+                    {
+                        lldb::user_id_t spec_uid = form_value.Reference();
+                        if (UserIDMatches(spec_uid))
+                        {
----------------
Using form_value.Reference() as a uid and then passing it to UserIDMatches still have the same issue as before, because form_value.Reference() will return a 32bit DIE offset (the return type might be 64bit, but the data will be only 32)

DIERef has a costructor taking a DWARFFormValue, please use that one and the get the UID from the DIERef (it will store the CU from the form_value, and know how to calculate UID based on it)


http://reviews.llvm.org/D12658