[Lldb-commits] [lldb] r246957 - Fixup TestRegisters after r246955

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 7 01:54:34 PDT 2015


Author: labath
Date: Mon Sep  7 03:54:34 2015
New Revision: 246957

URL: http://llvm.org/viewvc/llvm-project?rev=246957&view=rev
Log:
Fixup TestRegisters after r246955

- clang is picky about inline assembly: add the correct instruction size suffix
- mark the new test as expectedFailureClang: the test fails as the breakpoint is set in the wrong
  place

Modified:
    lldb/trunk/test/functionalities/register/TestRegisters.py
    lldb/trunk/test/functionalities/register/a.cpp

Modified: lldb/trunk/test/functionalities/register/TestRegisters.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/register/TestRegisters.py?rev=246957&r1=246956&r2=246957&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/register/TestRegisters.py (original)
+++ lldb/trunk/test/functionalities/register/TestRegisters.py Mon Sep  7 03:54:34 2015
@@ -35,6 +35,7 @@ class RegisterCommandsTestCase(TestBase)
         self.buildDefault()
         self.fp_register_write()
 
+    @expectedFailureClang("llvm.org/pr24733")
     def test_fp_special_purpose_register_read(self):
         """Test commands that read fpu special purpose registers."""
         if not self.getArchitecture() in ['amd64', 'i386', 'x86_64']:

Modified: lldb/trunk/test/functionalities/register/a.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/register/a.cpp?rev=246957&r1=246956&r2=246957&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/register/a.cpp (original)
+++ lldb/trunk/test/functionalities/register/a.cpp Mon Sep  7 03:54:34 2015
@@ -11,30 +11,31 @@
 long double
 return_long_double (long double value)
 {
-  float a=2, b=4,c=8, d=16, e=32, f=64, k=128, l=256, add=0;
-__asm__ ( "fld %1 ;"
-	"fld %2 ;"
-	"fld %3 ;"
-	"fld %4 ;"
-	"fld %5 ;"
-	"fld %6 ;"
-	"fld %7 ;"
-	"fadd ;" : "=g" (add) : "g" (a), "g" (b), "g" (c), "g" (d), "g" (e), "g" (f), "g" (k), "g" (l) );  // Set break point at this line.
-  return value;
+    float a=2, b=4,c=8, d=16, e=32, f=64, k=128, l=256, add=0;
+    __asm__ (
+        "flds %1 ;"
+        "flds %2 ;"
+        "flds %3 ;"
+        "flds %4 ;"
+        "flds %5 ;"
+        "flds %6 ;"
+        "flds %7 ;"
+        "faddp ;" : "=g" (add) : "g" (a), "g" (b), "g" (c), "g" (d), "g" (e), "g" (f), "g" (k), "g" (l) );  // Set break point at this line.
+    return value;
 }
 
 long double
 outer_return_long_double (long double value)
 {
-  long double val = return_long_double(value);
-  val *= 2 ;
-  return val;
+    long double val = return_long_double(value);
+    val *= 2 ;
+    return val;
 }
 
 long double
 outermost_return_long_double (long double value)
 {
-  long double val = outer_return_long_double(value);
-  val *= 2 ;
-  return val;
+    long double val = outer_return_long_double(value);
+    val *= 2 ;
+    return val;
 }




More information about the lldb-commits mailing list