[Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 4 15:57:47 PDT 2015
Correct, it doesn't do that prior to the patch. It looks like it's never
exiting this loop:
for worker in workers:
either when a Ctrl+C happens, or when all the processes finish. I guess
it's stuck in there for some reason. So even the test runner doesn't
finish. Still investigating.
Also to answer Greg's question, yes we were using dosep before. The
problem seems to be related to swtiching from multiprocess.Pool to doing
the pumping manually.
On Fri, Sep 4, 2015 at 3:54 PM Todd Fiala <todd.fiala at gmail.com> wrote:
> tfiala added a comment.
> In http://reviews.llvm.org/D12651#240439, @zturner wrote:
> > Hmm, yea the problem is worse than I thought. Even if I don't do Ctrl+C
> > all (I just run the test suite like I always have and let it finish)
> > just leaving a bunch of stale processes at the end without them shutting
> > down on their own.
> Ok, and it doesn't do that prior to the patch? (i.e. this isn't just a
> case of the processes slowly falling off at the end?)
> There's a point where all the worker processes are joined, which should
> mean they're done. So either the join is failing to complete (maybe
> because something in the process isn't wrapping up right), or the join
> isn't causing them to die.
> Is the initial test runner itself finishing up?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits