[Lldb-commits] [PATCH] D12641: Work around a race condition in lldbtest.py for Windows.
Adrian McCarthy via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 4 13:05:23 PDT 2015
amccarth updated this revision to Diff 34063.
amccarth added a comment.
I've put more detail in the comment.
@@ -1791,7 +1791,17 @@
# success! (and we don't want log files) delete log files
for log_file in log_files_for_this_test:
+ # We've seen consistent unlink failures on Windows, perhaps because the
+ # just-created log file is being scanned by anti-virus. Empirically, this
+ # sleep-and-retry approach allows tests to succeed much more reliably.
+ # Attempts to figure out exactly what process was still holding a file handle
+ # have failed because running instrumentation like Process Monitor seems to
+ # slow things down enough that the problem becomes much less consistent.
# Config. methods supported through a plugin interface
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1194 bytes
Desc: not available
More information about the lldb-commits