[Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 4 09:56:09 PDT 2015

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I would rather see the register variables laid out in a way which makes the offsets meaningful. I.e., instead of having m_fpr, m_gpr, ... we put something like

  struct Regs {
    uint32_t gpr[...];
    FPU fpu;
    DREG hbr_regs;
  Regs m_registers;

Then the byte offset field in Register Info structure will truly correspond to the offset in this structure, and we can index it simply with:

  assert(offset < sizeof m_register);
  address =  (char *)&m_registers + offset;

But if you want to keep this change small then it's ok for now.


More information about the lldb-commits mailing list