[Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

[Tamas Berghammer via lldb-commits]

tberghammer updated this revision to Diff 34038.
tberghammer added a comment.

Updated the change based on the comments.

I don't fully agree with restricting the user from setting breakpoint in non-code locations because if LLDB classified a section incorrectly (e.g. haven't found the SO file for it) the user might want to still set a breakpoint there. In general I would like to make it possible to set a breakpoint at any address (even on un-aligned ones) but warn the user that it might be incorrect.


http://reviews.llvm.org/D12556

Files:
  include/lldb/Core/Address.h
  source/API/SBFrame.cpp
  source/Core/Address.cpp
  source/Target/StackFrame.cpp
  source/Target/StackFrameList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12556.34038.patch
Type: text/x-patch
Size: 4448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150904/87dc1f29/attachment.bin>