[Lldb-commits] [PATCH] D12601: Fix TestLoadUnload.test_load_unload for android API > 21

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 4 03:18:29 PDT 2015

tberghammer added inline comments.

Comment at: source/Core/Module.cpp:1712
@@ -1712,1 +1711,3 @@
+        if (!FileSpec::Equal (file_spec, m_file, (bool)file_spec.GetDirectory()) &&
+            !FileSpec::Equal (file_spec, m_platform_file, (bool)file_spec.GetDirectory()))
             return false;
ovyalov wrote:
> It might expose some tricky problems when host and target have the same library with the same path but different content.. - please make sure that there is no regressions.  
I run the test suit and seen no regression.

If we have a library with the same path on the host and on the target and we don't have UUID then we are already having issues differentiating between them. In the case you described we treat them as matching modules even before my change.

Comment at: source/Target/Platform.cpp:278
@@ +277,3 @@
+                                      if (error.Success() && module_sp)
+                                          module_sp->SetPlatformFileSpec(spec.GetFileSpec());
+                                      return error;
ovyalov wrote:
> What do you think about putting module_sp->SetPlatformFileSpec(spec.GetFileSpec()) into ModuleList::GetSharedModule ?
I would like to limit the scope of this change to the case when remote debugging is used. It can be confusing if we set platform file spec even when no remote platform is involved


More information about the lldb-commits mailing list