[Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 3 17:39:47 PDT 2015
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
In general this looks good. It seems to me that in almost all the uses of ClangExpressionVariable::CreateVariableInList, you actually only want the ClangExpressionVariable *, since you pretty much always turn around an get that out of the ExpressionVariableSP anyway. So it might be more convenient to have CreateVariableInList return a ClangExpressionVariable *, and if you find yourself needing the ExpressionVariableSP, then just have ExpressionVariable implement shared_from_this, and you can use that to resurrect the shared pointer.
More information about the lldb-commits