[Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 3 07:25:56 PDT 2015


labath added a comment.

Looks good after fixing inverting one condition, but I would like to wait for an ok from zachary also. Linux builds fine after this patch.


================
Comment at: source/Host/common/GetOptInc.cpp:3
@@ +2,3 @@
+
+#if !defined(REPLACE_GETOPT) && !defined(REPLACE_GETOPT_LONG) && !defined(REPLACE_GETOPT_LONG_ONLY)
+
----------------
You have the logic reversed here. This should be #if defined(FOO) || defined(BAR) || defined(BAZ)


Repository:
  rL LLVM

http://reviews.llvm.org/D12582





More information about the lldb-commits mailing list