[Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

[Pavel Labath via lldb-commits]

It could possibly be a unit test (depending on e.g. whether we want to
test that function names from the current process are completed
properly as this test seems to be doing), but we could definitely test
most of the functionality through SBCommandInterpreter API. Any
volunteers for the job? :)

On 2 September 2015 at 15:58, Zachary Turner <zturner at google.com> wrote:
> Is pexpect actually needed for this test?  If it is for some reason, then
> just looking at the test it seems like we only really care about testing
> auto completion right?  Could it just be a unit test?  I think we should
> make it an explicit goal to avoid pexpect tests unless the test
> specificially requires launching lldb from the command line.
>
> On Wed, Sep 2, 2015 at 5:10 AM Pavel Labath via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>>
>> Author: labath
>> Date: Wed Sep  2 07:09:31 2015
>> New Revision: 246644
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=246644&view=rev
>> Log:
>> XFAIL new tests in TestCompletion on windows due to missing pexpect
>>
>> Modified:
>>     lldb/trunk/test/functionalities/completion/TestCompletion.py
>>
>> Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py
>> URL:
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/completion/TestCompletion.py?rev=246644&r1=246643&r2=246644&view=diff
>>
>> ==============================================================================
>> --- lldb/trunk/test/functionalities/completion/TestCompletion.py
>> (original)
>> +++ lldb/trunk/test/functionalities/completion/TestCompletion.py Wed Sep
>> 2 07:09:31 2015
>> @@ -219,6 +219,7 @@ class CommandLineCompletionTestCase(Test
>>          """Test that 'target va' completes to 'target variable '."""
>>          self.complete_from_to('target va', 'target variable ')
>>
>> +    @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect
>> replacement for windows")
>>      @skipUnlessDarwin
>>      @dsym_test
>>      def test_symbol_name_dsym(self):
>> @@ -228,6 +229,7 @@ class CommandLineCompletionTestCase(Test
>>                                'breakpoint set -n Foo::Bar(int,\\ int)',
>>                                turn_off_re_match=True)
>>
>> +    @expectedFailureHostWindows("llvm.org/pr22274: need a pexpect
>> replacement for windows")
>>      @dwarf_test
>>      def test_symbol_name_dwarf(self):
>>          self.buildDwarf()
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits