[Lldb-commits] [PATCH] D12515: Use -Wno-vla-extension globally.

Bruce Mitchener via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 31 20:14:27 PDT 2015


brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.

This was previously only established within debugserver, but
there is a use of the VLA extension in source/Host/macosx/Symbols.cpp,
so ignore this warning globally.

http://reviews.llvm.org/D12515

Files:
  cmake/modules/LLDBConfig.cmake
  tools/debugserver/source/CMakeLists.txt

Index: tools/debugserver/source/CMakeLists.txt
===================================================================
--- tools/debugserver/source/CMakeLists.txt
+++ tools/debugserver/source/CMakeLists.txt
@@ -16,12 +16,6 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
 endif ()
 
-check_cxx_compiler_flag("-Wno-vla-extension"
-                        CXX_SUPPORTS_NO_VLA_EXTENSION)
-if (CXX_SUPPORTS_NO_VLA_EXTENSION)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-vla-extension")
-endif ()
-
 check_cxx_compiler_flag("-Wno-zero-length-array"
                         CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY)
 if (CXX_SUPPORTS_NO_ZERO_LENGTH_ARRAY)
Index: cmake/modules/LLDBConfig.cmake
===================================================================
--- cmake/modules/LLDBConfig.cmake
+++ cmake/modules/LLDBConfig.cmake
@@ -114,6 +114,12 @@
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-register")
 endif ()
 
+check_cxx_compiler_flag("-Wno-vla-extension"
+                        CXX_SUPPORTS_NO_VLA_EXTENSION)
+if (CXX_SUPPORTS_NO_VLA_EXTENSION)
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-vla-extension")
+endif ()
+
 # Disable MSVC warnings
 if( MSVC )
   add_definitions(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12515.33660.patch
Type: text/x-patch
Size: 1232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150901/d41c2ab9/attachment.bin>


More information about the lldb-commits mailing list